gortiz commented on PR #16002: URL: https://github.com/apache/pinot/pull/16002#issuecomment-3003545061
As you said, in order to solve the compatibility failure we need to add deprecated a constructor without the new param. But that may be problematic if the new attribute is not nullable (which I'm assume it is not because it is not marked as such, but looks like it is set on an optional builder method, so I'm not sure). Alternatively, we can break backward compatibility here. But in that case I would suggest to make the single constructor of Common private, making it clear that the only correct way to instantiate it is by using the Builder. That is obviously a breaking change, but will prevent future breaking changes if we need to add new attributes in the future (because changing a private constructor is not a breaking change) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
