Copilot commented on code in PR #16002:
URL: https://github.com/apache/pinot/pull/16002#discussion_r2127752443
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/creator/GeoSpatialIndexCreator.java:
##########
@@ -35,7 +35,14 @@ public interface GeoSpatialIndexCreator extends IndexCreator
{
@Override
default void add(@Nonnull Object value, int dictId)
throws IOException {
- add(deserialize((byte[]) value));
+ Geometry geometry = null;
+ try {
+ geometry = deserialize((byte[]) value);
Review Comment:
Consider logging the caught exception (even at a debug level) in the
try-catch block to facilitate troubleshooting while still treating the geometry
as null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
