yashmayya opened a new pull request, #16189:
URL: https://github.com/apache/pinot/pull/16189
- Currently, dry-run table rebalances also go through the regular rebalance
API in `TableRebalanceManager`. There are a couple of issues with this:
- Parameters like `trackRebalanceProgress` and `allowRetries` are not
relevant for dry run rebalances.
- Dry-run rebalances can't result in `RebalanceInProgressException`, but
the callers would be forced to handle the checked exception anyway.
- (minor) For the sync API, the Javadoc states that the caller should
ensure that the rebalance is being run on the controller's rebalance specific
thread pool - this isn't relevant for dry runs.
- `trackRebalanceProgress` is no longer really needed after
https://github.com/apache/pinot/pull/16008. The `TableRebalanceManager` can
itself decide whether to track the rebalance progress in ZK based on the
rebalance config (the only cases where it's not tracked are downtime rebalances
and dry-run rebalances).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
