gortiz commented on PR #16103: URL: https://github.com/apache/pinot/pull/16103#issuecomment-2979452929
In general I like the PR, but I would prefer a solution where we don't need to create a new index concept but instead just codify this feature as an internal property of the single-column text index (maybe with a syntax like https://github.com/apache/pinot/pull/16103#issuecomment-2979347157). I think this perspective has several advantages (easier to explain, keeps using the same syntax... in general, it is simpler), but I don't know if it is technically possible. This is why I said I missed a design document where we could discuss the feature from a different perspective. With Index SPI, we spend a significant amount of time trying to find a way to specify indexes that can reduce the cognitive complexity associated with them, and this PR is a step backward. That doesn't have to be a blocker (sometimes it is needed), but I would like to be sure there was no other option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
