gortiz commented on code in PR #16103:
URL: https://github.com/apache/pinot/pull/16103#discussion_r2151654606


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessor.java:
##########
@@ -158,8 +170,17 @@ public void process(@Nullable SegmentOperationsThrottler 
segmentOperationsThrott
     // that the other required indices (e.g. forward index) are up-to-date.
     try (SegmentDirectory.Writer segmentWriter = 
_segmentDirectory.createWriter()) {
       if (processStarTrees(indexDir, segmentOperationsThrottler)) {
-        // NOTE: When adding new steps after this, un-comment the next line.

Review Comment:
   Should we keep this comment, moved to line 183 so we don't forget to reload 
metadata if we add more steps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to