gortiz commented on code in PR #16007:
URL: https://github.com/apache/pinot/pull/16007#discussion_r2149666898
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -200,6 +217,52 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ private static Level successfulSummarizeLevel(SqlNodeAndOptions
sqlNodeAndOptions) {
+ String key =
CommonConstants.MultiStageQueryRunner.KEY_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String defaultValue =
CommonConstants.MultiStageQueryRunner.DEFAULT_OF_SUCCESSFUL_SUMMARIZE_LOG;
+ String str = sqlNodeAndOptions.getOptions().getOrDefault(key,
defaultValue);
Review Comment:
These logs may be pretty large, which means that they can be very verbose in
high QPS environments, so this log should not be included by default in queries
that succeed. But users may want to log specific queries even when they succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
