Jackie-Jiang commented on code in PR #16007:
URL: https://github.com/apache/pinot/pull/16007#discussion_r2129675780
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -197,7 +197,7 @@ private void splitAndSend(MseBlock block, List<DataBuffer>
serializedStats)
}
int sizeInBytes =
byteStrings.stream().mapToInt(ByteString::size).reduce(0, Integer::sum);
if (LOGGER.isDebugEnabled()) {
- LOGGER.debug("Serialized block: {} to {} bytes", block, sizeInBytes);
+ LOGGER.debug("debugSerialized block: {} to {} bytes", block,
sizeInBytes);
Review Comment:
Is this change intended?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -200,6 +216,19 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
}
}
+ private void summarizeQuery(long requestId, BrokerResponse brokerResponse) {
+ ObjectNode stats = brokerResponse instanceof BrokerResponseNativeV2
+ ? ((BrokerResponseNativeV2) brokerResponse).getStageStats()
+ : JsonNodeFactory.instance.objectNode();
+ if (brokerResponse.getExceptions().isEmpty()) {
+ LOGGER.debug(MSE_STATS_MARKER, "Request {} finished in {}ms. Errors: {}.
Stats: {}",
Review Comment:
Exception is always empty here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
