somandal commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2146138798
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/DefaultTenantRebalancer.java:
##########
@@ -184,16 +277,16 @@ private String createUniqueRebalanceJobIdentifier() {
return UUID.randomUUID().toString();
}
- private Set<String> getTenantTables(String tenantName) {
+ public Set<String> getTenantTables(String tenantName) {
Review Comment:
nit: forgot to call this out last time, but can this be package private if
possible and can you mark it as @VisibleForTesting if it's only exposed for
testing purposes? I at least didn't see it used outside of tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
