Jackie-Jiang commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2143908804
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -239,12 +240,14 @@ public SegmentMetadataImpl getSegmentMetadata() {
@Override
public DataSource getDataSource(String column, Schema schema) {
DataSource dataSource = getDataSourceNullable(column);
- if (dataSource == null) {
- dataSource = IndexSegmentUtils.getVirtualDataSource(schema,
_segmentMetadata.getSchema(), column,
- _segmentMetadata.getTotalDocs());
- _dataSources.put(column, dataSource);
+ if (dataSource != null) {
+ return dataSource;
}
- return dataSource;
+ FieldSpec fieldSpec = schema.getFieldSpecFor(column);
Review Comment:
I don't follow. Why would this cause a problem?
We will reach here when the segment schema doesn't have the column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
