praveenc7 commented on code in PR #15350:
URL: https://github.com/apache/pinot/pull/15350#discussion_r2125512834
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/IndexSegment.java:
##########
@@ -76,10 +76,9 @@ default DataSource getDataSource(String column) {
/// Returns the [DataSource] for the given column, or creates a virtual one
if it doesn't exist. The passed in
/// [Schema] should be the latest schema of the table, not the one from
[SegmentMetadata], and should contain the
/// asked column.
- /// TODO: Add support for virtual [DataSource].
- default DataSource getDataSource(String column, Schema schema) {
- return getDataSource(column);
- }
+ default DataSource getDataSource(String column, Schema schema) {
Review Comment:
It is used in Empty segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
