somandal commented on code in PR #16079:
URL: https://github.com/apache/pinot/pull/16079#discussion_r2141158012
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java:
##########
@@ -147,6 +147,9 @@ public static void validate(Schema schema, boolean
isIgnoreCase) {
.equals(FieldSpec.DataType.DOUBLE)) {
validateDefaultIsNotNaN(fieldSpec);
}
+ if (!fieldSpec.isSingleValueField()) {
Review Comment:
moved this check outside that if condition
we should revisit them all though, right? why are other validations not done
for virtualColumns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
