somandal commented on code in PR #16079:
URL: https://github.com/apache/pinot/pull/16079#discussion_r2141157474
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -714,6 +714,12 @@ static void validateUpsertAndDedupConfig(TableConfig
tableConfig, Schema schema)
// primary key exists
Preconditions.checkState(CollectionUtils.isNotEmpty(schema.getPrimaryKeyColumns()),
"Upsert/Dedup table must have primary key columns in the schema");
+ // primary key columns are not of multi-value type
+ for (String primaryKeyColumn : schema.getPrimaryKeyColumns()) {
+ FieldSpec fieldSpec = schema.getFieldSpecFor(primaryKeyColumn);
+ Preconditions.checkState(fieldSpec.isSingleValueField(),
Review Comment:
added
but had left it out originally because it looks like having a fieldSpec is a
must for primaryKeyColumns:
https://github.com/apache/pinot/blob/b8900834e5f73dc94e810f5f0708555d9d19ff7d/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SchemaUtils.java#L155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
