vrajat commented on issue #16015: URL: https://github.com/apache/pinot/issues/16015#issuecomment-2963484075
Yes. They will be treated as the same query. The degenerate case is a high qps workload with many concurrent queries and same correlation id. IIUC from the docs, the best practice for clients is to provide unique ids ? Is it sufficient if we add a warning to docs that non-unique correlation ids may affect features like OOM protection ? I like the idea of using correlation id because it will make it easier to match logs of OOM protection as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org