somandal commented on code in PR #16008:
URL: https://github.com/apache/pinot/pull/16008#discussion_r2138766780
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceChecker.java:
##########
@@ -279,6 +279,10 @@ static Map<String, Set<Pair<TableRebalanceContext, Long>>>
getCandidateJobs(Stri
}
TableRebalanceProgressStats jobStats =
JsonUtils.stringToObject(jobStatsInStr, TableRebalanceProgressStats.class);
TableRebalanceContext jobCtx = JsonUtils.stringToObject(jobCtxInStr,
TableRebalanceContext.class);
+ if (!jobCtx.getAllowRetries()) {
+ LOGGER.debug("Skip rebalance job: {} as it does not allow retries",
jobId);
Review Comment:
nit: should we make this info? just for easier debugging?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java:
##########
@@ -233,7 +233,7 @@ private void rebalanceTable(String tableNameWithType) {
// We're not using the async rebalance API here because we want to run
this on a separate thread pool from the
// rebalance thread pool that is used for user initiated rebalances.
RebalanceResult rebalance =
_tableRebalanceManager.rebalanceTable(tableNameWithType, rebalanceConfig,
- TableRebalancer.createUniqueRebalanceJobIdentifier(), false);
+ TableRebalancer.createUniqueRebalanceJobIdentifier(), true, false);
Review Comment:
nit: perhaps add a comment here on why setting allowRetries to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
