gortiz commented on code in PR #15919:
URL: https://github.com/apache/pinot/pull/15919#discussion_r2132208909
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java:
##########
@@ -69,6 +71,17 @@ public static MetadataBlock newEosWithStats(List<DataBuffer>
statsByStage) {
public MetadataBlock(List<DataBuffer> statsByStage) {
Review Comment:
> Is there scenario where stageId and workerId are unavailable?
Yes, MetadataBlock is used to serialize any EOS, including those that
succeed and those that don't. But stageId and workerId are only used on error
blocks. We could include them in successful blocks as well, but that won't be
very useful and would make SuccessMseBlock stateful, which is not great given
they can be used as singletons now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
