Copilot commented on code in PR #16027:
URL: https://github.com/apache/pinot/pull/16027#discussion_r2131820898
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -352,6 +355,18 @@ public void indexRow(GenericRow row)
_docIdCounter++;
}
+ private boolean skipRowIfNeeded(GenericRow row) {
+ for (String columnName : _schema.getColumnNames()) {
+ FieldSpec fieldSpec = _schema.getFieldSpecFor(columnName);
+ if (fieldSpec.isNotNull() && row.getValue(columnName) == null) {
+ // If column is not nullable and not present in the row, skip the row
+ LOGGER.info("Skipping row because the not-null column {} is not
present in the row", columnName);
Review Comment:
Consider using a lower log level (e.g., DEBUG) instead of INFO to prevent
excessive logging in production when many rows may be skipped.
```suggestion
LOGGER.debug("Skipping row because the not-null column {} is not
present in the row", columnName);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
