J-HowHuang commented on code in PR #15891:
URL: https://github.com/apache/pinot/pull/15891#discussion_r2124365913
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalancer.java:
##########
@@ -18,6 +18,10 @@
*/
package org.apache.pinot.controller.helix.core.rebalance.tenant;
+import java.util.Set;
+
+
public interface TenantRebalancer {
TenantRebalanceResult rebalance(TenantRebalanceConfig config);
+ Set<String> getTenantTables(String tenantName);
Review Comment:
I did added a util in `TableConfigUtils` and had
`PinotTenantRestletResource.getTablesServedFromServerTenant` make use of that.
The interface method here was to allow the testing of the correctness of
this method, because in the original test it was testing a `TenantRebalancer`
instance instead of `DefaultTenantRebalancer` instance. I can remove this
method from the interface and test only on `DefaultTenantRebalancer` either,
what's your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
