somandal commented on code in PR #15891: URL: https://github.com/apache/pinot/pull/15891#discussion_r2114491521
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/tenant/TenantRebalanceConfig.java: ########## @@ -71,6 +88,25 @@ public void setParallelBlacklist(Set<String> parallelBlacklist) { _parallelBlacklist = parallelBlacklist; } + @ApiModelProperty(hidden = true) + public Set<String> getAllowTables() { + return _allowTables; + } + + public void setAllowTables(Set<String> allowTables) { + _allowTables = allowTables; + } + + @ApiModelProperty(hidden = true) + public Set<String> getBlockTables() { + return _blockTables; + } + + public void setBlockTables(Set<String> blockTables) { + _blockTables = blockTables; + } + + @ApiModelProperty(hidden = true) Review Comment: Yet to look at the full code in detail, but will marking these as `hidden = true` break backward compatibility for users that use these properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org