xiangfu0 commented on code in PR #15606:
URL: https://github.com/apache/pinot/pull/15606#discussion_r2116316666
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -117,7 +117,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- int hash = 31 * 31 * _type.hashCode();
+ int hash = 31 * 31 * _type.toString().hashCode();
Review Comment:
true, however for enum, the hashcode() method is stable within the JVM
process, but not stable across multiple JVMs. to ensure the hashcode is stable,
we need to use the string hash.
Maybe we could cache all the hashcode in a Map to speed up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
