Jackie-Jiang commented on code in PR #15606:
URL: https://github.com/apache/pinot/pull/15606#discussion_r2078502594
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -117,7 +117,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- int hash = 31 * 31 * _type.hashCode();
+ int hash = 31 * 31 * _type.toString().hashCode();
Review Comment:
Why? It is adding unnecessary overhead
##########
pinot-common/src/main/java/org/apache/pinot/common/cache/QueryCache.java:
##########
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.cache;
+
+import org.apache.pinot.common.request.context.FilterContext;
+
+
+public interface QueryCache {
+ /**
+ * Put the given key-value pair into the cache.
+ *
+ * @param key The key to be put into the cache
+ * @param value The value to be put into the cache
+ */
+ void put(String key, Object value);
+
+ /**
+ * Get the value for the given key from the cache.
+ *
+ * @param key The key to get from the cache
+ * @return The value for the given key, or null if not found
+ */
+ Object get(String key);
+
+ /**
+ * Remove the given key from the cache.
+ *
+ * @param key The key to remove from the cache
+ */
+ void remove(String key);
+
+ /**
+ * Get the cache key for the given table, segment name, and filter context.
+ * @param segmentName The segment name
+ * @param filterContext The filter context
+ * @return The cache key
+ */
+ static String getCacheKey(String segmentName, FilterContext filterContext) {
+ return segmentName + "_" + filterContext.hashCode();
Review Comment:
What is the chance of hash collision?
##########
pinot-common/src/main/java/org/apache/pinot/common/cache/QueryCache.java:
##########
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.cache;
+
+import org.apache.pinot.common.request.context.FilterContext;
+
+
+public interface QueryCache {
+ /**
+ * Put the given key-value pair into the cache.
+ *
+ * @param key The key to be put into the cache
+ * @param value The value to be put into the cache
+ */
+ void put(String key, Object value);
+
+ /**
+ * Get the value for the given key from the cache.
+ *
+ * @param key The key to get from the cache
+ * @return The value for the given key, or null if not found
+ */
+ Object get(String key);
+
+ /**
+ * Remove the given key from the cache.
+ *
+ * @param key The key to remove from the cache
+ */
+ void remove(String key);
+
+ /**
+ * Get the cache key for the given table, segment name, and filter context.
+ * @param segmentName The segment name
+ * @param filterContext The filter context
+ * @return The cache key
+ */
+ static String getCacheKey(String segmentName, FilterContext filterContext) {
+ return segmentName + "_" + filterContext.hashCode();
Review Comment:
Do you need `segmentName` as part of the key?
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java:
##########
@@ -196,6 +202,15 @@ private boolean canApplyH3IndexForInclusionCheck(Predicate
predicate, FunctionCo
* Helper method to build the operator tree from the filter.
*/
private BaseFilterOperator constructPhysicalOperator(FilterContext filter,
int numDocs) {
+ if (_queryCache != null) {
Review Comment:
Do we invalidate cache when segment is replaced?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/QueryConfig.java:
##########
@@ -56,13 +56,27 @@ public class QueryConfig extends BaseJsonConfig {
// Indicates the maximum length of the serialized response per server for a
query.
private final Long _maxServerResponseSizeBytes;
- @JsonCreator
+ // Table config override for query cache
+ private final CacheConfig _cacheConfig;
+
public QueryConfig(@JsonProperty("timeoutMs") @Nullable Long timeoutMs,
@JsonProperty("disableGroovy") @Nullable Boolean disableGroovy,
@JsonProperty("useApproximateFunction") @Nullable Boolean
useApproximateFunction,
@JsonProperty("expressionOverrideMap") @Nullable Map<String, String>
expressionOverrideMap,
@JsonProperty("maxQueryResponseSizeBytes") @Nullable Long
maxQueryResponseSizeBytes,
@JsonProperty("maxServerResponseSizeBytes") @Nullable Long
maxServerResponseSizeBytes) {
+ this(timeoutMs, disableGroovy, useApproximateFunction,
expressionOverrideMap, maxQueryResponseSizeBytes,
+ maxServerResponseSizeBytes, null);
+ }
+
+ @JsonCreator
+ public QueryConfig(@JsonProperty("timeoutMs") @Nullable Long timeoutMs,
Review Comment:
(minor) You only need to annotate one constructor. If you decide to keep the
other constructor, then no need to change the usage in other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
