anandheritage commented on PR #15844: URL: https://github.com/apache/pinot/pull/15844#issuecomment-2903527609
> This algorithm can be extended to support group-by with ordering on keys only (no order-by on aggregated values). When there is no order-by, we can treat it as ordering on all keys. Ideally, we want to do the following improvement: > > * Within segment, maintain only the top `LIMIT` keys. Given the key doesn't change, we can skip adding keys when the map size is the same as `LIMIT`, and the new key is smaller than the smallest top key > * Across segments, we can do what you are doing here > * We don't need trim for this approach, and the result is always accurate Thanks for the suggestion — I completely agree that the algorithm can be generalized in that direction. Will create a separate task and pick that up too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
