noob-se7en commented on code in PR #15831:
URL: https://github.com/apache/pinot/pull/15831#discussion_r2100174310
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -301,7 +301,7 @@ public void updateIngestionMetrics(String segmentName, int
partitionId, long ing
long firstStreamIngestionTimeMs, @Nullable StreamPartitionMsgOffset
currentOffset,
@Nullable StreamPartitionMsgOffset latestOffset) {
_ingestionDelayTracker.updateIngestionMetrics(segmentName, partitionId,
ingestionTimeMs, firstStreamIngestionTimeMs,
- currentOffset, latestOffset);
+ currentOffset);
Review Comment:
If we decide against above then let's clean up all parent methods calling
this method passing latestOffset. As latestOffset is also fetched in
updateIngestionMetrics of `RealtimeSegmentDataManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
