KKcorps commented on code in PR #15831:
URL: https://github.com/apache/pinot/pull/15831#discussion_r2094827408


##########
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTrackerTest.java:
##########
@@ -309,26 +368,26 @@ public void testRecordIngestionDelayOffset() {
     // Test tracking offset lag for a single partition
     StreamPartitionMsgOffset msgOffset0 = new LongMsgOffset(50);
     StreamPartitionMsgOffset latestOffset0 = new LongMsgOffset(150);
-    ingestionDelayTracker.updateIngestionMetrics(segment0, partition0, 
Long.MIN_VALUE, Long.MIN_VALUE, msgOffset0,
-        latestOffset0);
+    ingestionDelayTracker.updateIngestionMetrics(segment0, partition0, 
Long.MIN_VALUE, Long.MIN_VALUE, msgOffset0);
+    ingestionDelayTracker.updateOffsetLagForPartition(partition0, 
latestOffset0);

Review Comment:
   Ignore this for now, working on a way to mock it instead of passing offset 
directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to