shauryachats commented on code in PR #15762:
URL: https://github.com/apache/pinot/pull/15762#discussion_r2096075026
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserver.java:
##########
@@ -51,8 +52,10 @@ public class MailboxContentObserver implements
StreamObserver<MailboxContent> {
private final List<ByteBuffer> _mailboxBuffers;
private transient ReceivingMailbox _mailbox;
- public MailboxContentObserver(MailboxService mailboxService,
StreamObserver<MailboxStatus> responseObserver) {
+ public MailboxContentObserver(
+ MailboxService mailboxService, String mailboxId,
StreamObserver<MailboxStatus> responseObserver) {
_mailboxService = mailboxService;
+ _mailbox = StringUtils.isNotBlank(mailboxId) ?
_mailboxService.getReceivingMailbox(mailboxId) : null;
Review Comment:
When performing an incremental update from older versions to the version
that includes this change, some servers may still be running the previous
build, which initializes the mailbox using onNext only. To prevent query
failures during this transition period, this logic has been retained. (This
issue was also identified by the compatibility regression integration tests.)
We can consider removing this in the next major version upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
