ankitsultana commented on code in PR #15762: URL: https://github.com/apache/pinot/pull/15762#discussion_r2087357906
########## pinot-query-runtime/src/test/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserverTest.java: ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.mailbox.channel; + +import com.google.protobuf.ByteString; +import io.grpc.stub.StreamObserver; +import org.apache.pinot.common.proto.Mailbox.MailboxContent; +import org.apache.pinot.common.proto.Mailbox.MailboxStatus; +import org.apache.pinot.query.mailbox.MailboxService; +import org.apache.pinot.query.mailbox.ReceivingMailbox; +import org.mockito.Mockito; +import org.testng.annotations.Test; + +import static org.mockito.Mockito.*; + +public class MailboxContentObserverTest { + + private static final String TEST_MAILBOX_ID = "test-mailbox-id"; Review Comment: nit: space between next method ########## pinot-query-runtime/src/test/java/org/apache/pinot/query/mailbox/channel/MailboxContentObserverTest.java: ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.mailbox.channel; + +import com.google.protobuf.ByteString; +import io.grpc.stub.StreamObserver; +import org.apache.pinot.common.proto.Mailbox.MailboxContent; +import org.apache.pinot.common.proto.Mailbox.MailboxStatus; +import org.apache.pinot.query.mailbox.MailboxService; +import org.apache.pinot.query.mailbox.ReceivingMailbox; +import org.mockito.Mockito; +import org.testng.annotations.Test; + +import static org.mockito.Mockito.*; + +public class MailboxContentObserverTest { + + private static final String TEST_MAILBOX_ID = "test-mailbox-id"; + @Test + public void testMailboxContentObserverInitializationAndFetch() { + MailboxService mailboxService = mock(MailboxService.class); + ReceivingMailbox receivingMailbox = mock(ReceivingMailbox.class); + when(mailboxService.getReceivingMailbox(TEST_MAILBOX_ID)).thenReturn(receivingMailbox); + StreamObserver<MailboxStatus> mockStatusObserver = mock(StreamObserver.class); + Review Comment: nit / opinionated: I think using empty lines is an anti-pattern since everyone has different opinions about how they view blocks of code and overtime the code can kinda look very inconsistent. It also interrupts the flow of the reader a bit. My opinion there is to prefer single-line comments rather than empty lines. But I'll leave it up to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
