vrajat commented on code in PR #15720: URL: https://github.com/apache/pinot/pull/15720#discussion_r2077657185
########## pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java: ########## @@ -197,6 +200,88 @@ public void testLogicalTableValidationTests() assertTrue(e.getMessage().contains("Reason: 'InvalidTenant' should be one of the existing broker tenants"), e.getMessage()); } + + // Test ref offline table name is null validation Review Comment: Yes. Individual tests. Also that will improve the test report. We will know which exact test failed. (Assuming the test function names are descriptive) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org