abhishekbafna commented on code in PR #15720:
URL: https://github.com/apache/pinot/pull/15720#discussion_r2077470817
##########
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotLogicalTableResourceTest.java:
##########
@@ -197,6 +200,88 @@ public void testLogicalTableValidationTests()
assertTrue(e.getMessage().contains("Reason: 'InvalidTenant' should be
one of the existing broker tenants"),
e.getMessage());
}
+
+ // Test ref offline table name is null validation
Review Comment:
I have been all adding all the validation related tests under a single test.
I agree that it is getting bigger and would complex soon, if not already.
what is your thinking on the separating these tests? Should these be
individual tests or something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
