Copilot commented on code in PR #15734:
URL: https://github.com/apache/pinot/pull/15734#discussion_r2077600049
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/ReplicaGroupSegmentAssignmentStrategy.java:
##########
@@ -40,9 +40,9 @@
class ReplicaGroupSegmentAssignmentStrategy implements
SegmentAssignmentStrategy {
private static final Logger LOGGER =
LoggerFactory.getLogger(ReplicaGroupSegmentAssignmentStrategy.class);
- private static HelixManager _helixManager;
- private static String _tableName;
- private static String _partitionColumn;
+ private HelixManager _helixManager;
Review Comment:
Changing the metadata variable from a static to an instance variable
resolves potential concurrency issues when multiple tables are processed
concurrently. Ensure that all other usages of these fields are updated
accordingly to maintain object encapsulation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
