yashmayya opened a new pull request, #15734: URL: https://github.com/apache/pinot/pull/15734
- It's unclear why these were static variables in the first place, and it seems like this has gone unnoticed for so long only because all usages seem to be creating a new instance of the `SegmentAssignmentStrategy` right before calling `assignSegment` or `reassignSegments`. - That isn't bulletproof though and we could run into all kinds of weird issues if multiple tables using replica groups require segments to be assigned or rebalanced concurrently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
