Jackie-Jiang commented on code in PR #15673:
URL: https://github.com/apache/pinot/pull/15673#discussion_r2070586577
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -105,7 +105,7 @@ public static synchronized void
setMinNumCharsInISToTurnOnCompression(int minNum
* @param helixManager helixManager with the ability to pull from the
current data\
* @param resourceName the resource name to be updated
* @param updater the idealState updater to be applied
- * @return IdealState if the update is successful, null if not
+ * @return IdealState if the update is successful, exception if not and null
if interrupted while committing change
Review Comment:
Are we getting exception here? I think the existing comment is more accurate
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java:
##########
@@ -105,7 +105,7 @@ public static synchronized void
setMinNumCharsInISToTurnOnCompression(int minNum
* @param helixManager helixManager with the ability to pull from the
current data\
* @param resourceName the resource name to be updated
* @param updater the idealState updater to be applied
- * @return IdealState if the update is successful, null if not
+ * @return IdealState if the update is successful, exception if not and null
if interrupted while committing change
Review Comment:
Or are you referring to the `PermanentUpdaterException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
