Jackie-Jiang commented on code in PR #15681:
URL: https://github.com/apache/pinot/pull/15681#discussion_r2069316146
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java:
##########
@@ -196,6 +204,14 @@ private void rebalanceTable(String tableNameWithType) {
rebalanceConfig.setMinimizeDataMovement(_minimizeDataMovement);
try {
+ if (_tablesUndergoingRebalance != null) {
Review Comment:
We should move this outside of the `try-catch` block. When early terminated,
we shouldn't call `remove()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
