yashmayya commented on code in PR #15681: URL: https://github.com/apache/pinot/pull/15681#discussion_r2069210950
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/SegmentRelocator.java: ########## @@ -80,6 +80,7 @@ public class SegmentRelocator extends ControllerPeriodicTask<Void> { private final Set<String> _waitingTables; private final BlockingQueue<String> _waitingQueue; + private final Set<String> _tablesUndergoingRebalance; Review Comment: nit: let's annotate this with `@Nullable` to reduce the chances of NPEs since this is gonna be `null` for the sequential mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org