chenboat commented on code in PR #15120:
URL: https://github.com/apache/pinot/pull/15120#discussion_r2065095621
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableDictionary.java:
##########
@@ -48,4 +48,11 @@ default int insertionIndexOf(String stringValue) {
// This method should not be called for unsorted dictionary.
throw new UnsupportedOperationException();
}
+
+ /**
+ * This method returns a boolean denoting whether the mutable dictionary can
consume any more rows or not.
Review Comment:
Make it clear by saying "Return true if the mutable dictionary can consume
an additional row"
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -189,6 +178,11 @@ public class MutableSegmentImpl implements MutableSegment {
// the valid doc ids won't be updated.
private final ThreadSafeMutableRoaringBitmap _validDocIds;
private final ThreadSafeMutableRoaringBitmap _queryableDocIds;
+ private boolean _indexCapacityThresholdBreached;
Review Comment:
Is this threshold check for all indexes/dictionaries in one segment?
Suggest to rename to _indexThresholdReached and also add javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
