noob-se7en commented on code in PR #15120:
URL: https://github.com/apache/pinot/pull/15120#discussion_r2059092527
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableDictionary.java:
##########
@@ -48,4 +48,11 @@ default int insertionIndexOf(String stringValue) {
// This method should not be called for unsorted dictionary.
throw new UnsupportedOperationException();
}
+
+ /**
+ * This method returns a boolean denoting whether the mutable index can
consume any more rows or not.
Review Comment:
```suggestion
* This method returns a boolean denoting whether the mutable dictionary
can consume any more rows or not.
```
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/forward/mutable/VarByteSVMutableForwardIndexTest.java:
##########
@@ -82,6 +83,7 @@ public void testBytes()
try (VarByteSVMutableForwardIndex readerWriter = new
VarByteSVMutableForwardIndex(DataType.STRING, _memoryManager,
"StringColumn", initialCapacity, estimatedAvgStringLength)) {
int rows = 1000;
+ int totalLength = 0;
Review Comment:
this is being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
