Jackie-Jiang commented on code in PR #15595:
URL: https://github.com/apache/pinot/pull/15595#discussion_r2052861109
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java:
##########
@@ -60,39 +61,56 @@ private HelixSetupUtils() {
private static final Logger LOGGER =
LoggerFactory.getLogger(HelixSetupUtils.class);
- public static HelixManager setupHelixController(String helixClusterName,
String zkPath, String instanceId) {
- setupHelixClusterIfNeeded(helixClusterName, zkPath);
- return HelixControllerMain
- .startHelixController(zkPath, helixClusterName, instanceId,
HelixControllerMain.STANDALONE);
- }
-
- private static void setupHelixClusterIfNeeded(String helixClusterName,
String zkPath) {
- HelixAdmin admin = null;
+ public static void setupHelixClusterWithDefaultConfigs(String zkAddress,
String clusterName,
Review Comment:
Sounds good. Adding javadoc and also changing the log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
