raghavyadav01 commented on code in PR #15510: URL: https://github.com/apache/pinot/pull/15510#discussion_r2047764716
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ########## @@ -100,6 +110,12 @@ public void onTrigger(Trigger trigger, Map<String, Map<String, String>> currentS } break; case EXTERNAL_VIEW_TO_IDEAL_STATE_CONVERGENCE_TRIGGER: + // Update the previous stats with the current values in case a rollback is needed due to IdealState version + // change + _previousStepStats = new TableRebalanceProgressStats.RebalanceProgressStats( Review Comment: If I understand correctly at each state change trigger we save the current stats and use it in rollback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org