somandal opened a new pull request, #15510: URL: https://github.com/apache/pinot/pull/15510
As part of PR https://github.com/apache/pinot/pull/15266, progress stats were enhanced for Table rebalance. A scenario (details: https://github.com/apache/pinot/pull/15266#issuecomment-2779453530) was found where under scenarios where IdealState update fails due to version change, the progress stats may not reflect correctly. This PR addresses the above by adding a rollback mechanism to rollback the stats when the above scenario is detected. This scenario is more likely to be hit when `bestEffort=true`. Testing: - Did testing with `HybridQuickStart`: - `StrictReplicaGroupAssignment` testing (which keeps detecting newly added segments tracked by rebalance) - forceCommit during rebalance for REALTIME tables - bestEfforts=true testing - Offline / realtime table testing Verified that the rollback code is indeed called when the IS update fails due to version change and stats are correctly rolled back to before the IS update cc @raghavyadav01 @J-HowHuang @klsince @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
