Jackie-Jiang commented on code in PR #15419:
URL: https://github.com/apache/pinot/pull/15419#discussion_r2025393695
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -747,6 +747,14 @@ public void run() {
_segmentLogger.info("Acquired consumer semaphore.");
+ // Refresh segment end criteria time. This is to avoid scenarios where
consumer waits a longer period of time
+ // before acquiring semaphore. These scenarios can lead to creation of
small segments because segment
+ // consumption is terminated early.
+ _consumeStartTime = now();
+ setConsumeEndTime(_segmentZKMetadata, _consumeStartTime);
Review Comment:
This has side effect of different replicas stops at different time. We need
to use the time in the constructor so that the time is relatively aligned for
the commit protocol to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
