rhodo opened a new pull request, #15471:
URL: https://github.com/apache/pinot/pull/15471

   This change follows up on 
[#15429](https://github.com/apache/pinot/pull/15429) and makes PinotTaskManager 
fully pluggable.
   
   Currently, the constructor of PinotTaskManager includes code paths—such as 
checkTableConfigChanges()—that can lead to the invocation of 
updateCronTaskScheduler(). This method is overridable and may be overridden in 
a subclass. Invoking it during the base class constructor can lead to bugs if 
the derived class is not fully initialized yet.
   
   This update ensures that such calls are deferred appropriately to avoid 
potential issues during construction. Use existing tests to confirm it does not 
introduce regressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to