9aman opened a new pull request, #15470:
URL: https://github.com/apache/pinot/pull/15470

   ## Context
   
   The metric `PAUSELESS_CONSUMPTION_ENABLED` was not getting scraped by 
Prometheus due to regex mismatch. 
   We had two options:
   1. Simplify the metric
   2. Add another regex to allow scarping this metric
   
   ## Scope of the PR
   
   The PR changes the tag for the metric to just table name as this metric is 
agnostic of the partition at hand. Moreover, logs have the exact information of 
the `fsm` picked for each partition in case this is needed for debugging. 
   
   Using `avg` of this metric for each controller can give us additional 
information on whether each partition is using the same fsm or not. The `avg` 
value should either be 0 or 1 (i.e. the value of this metric is 0 or 1 for all 
the partitions).
   
   ### When can the value be between 0 and 1
   Enabling/ disabling pauseless flag without pausing the ingestion can lead to 
a situation where some partitions use `BlockingFSM` while other's use 
`PauselessFSM`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to