Jackie-Jiang commented on code in PR #15088:
URL: https://github.com/apache/pinot/pull/15088#discussion_r2012909684
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -453,6 +453,8 @@ public static class Broker {
public static final String
CONFIG_OF_BROKER_ENABLE_MULTISTAGE_MIGRATION_METRIC =
"pinot.broker.enable.multistage.migration.metric";
public static final boolean DEFAULT_ENABLE_MULTISTAGE_MIGRATION_METRIC =
false;
+ public static final String GRPC_SERVER_ENABLED =
"pinot.broker.grpc.server.enabled";
+ public static final boolean DEFAULT_GRPC_SERVER_ENABLED = false;
Review Comment:
For consistency
```suggestion
public static final String CONFIG_OF_BROKER_ENABLE_GRPC_SERVER =
"pinot.broker.enable.grpc.server";
public static final boolean DEFAULT_BROKER_ENABLE_GRPC_SERVER = false;
```
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -123,6 +123,7 @@ public class ControllerTest {
protected int _nextBrokerPort = _nextControllerPort + 1000;
protected int _nextServerPort = _nextBrokerPort + 1000;
protected int _nextMinionPort = _nextServerPort + 1000;
+ protected int _nextBrokerGrpcPort = _nextMinionPort + 1000;
Review Comment:
Let's make it `_nextBrokerPort + 500` to keep the port for each component
together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
