Jackie-Jiang commented on code in PR #15088:
URL: https://github.com/apache/pinot/pull/15088#discussion_r2011075925
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java:
##########
@@ -147,9 +159,18 @@ private BrokerData getBrokerData(Map<String,
List<BrokerInstance>> responses) {
for (Map.Entry<String, List<BrokerInstance>> tableToBrokers :
responses.entrySet()) {
List<String> brokersForTable = new ArrayList<>();
tableToBrokers.getValue().forEach(br -> {
- String brokerHostPort = br.getHost() + ":" + br.getPort();
- brokersForTable.add(brokerHostPort);
- brokers.add(brokerHostPort);
+ if (_useGrpcPort) {
+ Integer grpcPort = br.getGrpcPort();
+ if ((grpcPort != null) && (grpcPort > 0)) {
Review Comment:
Seems like you intentionally want to skip these brokers. Suggest adding some
comments about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
