albertobastos commented on code in PR #15264:
URL: https://github.com/apache/pinot/pull/15264#discussion_r2007299497
##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -88,9 +87,12 @@ public void log(QueryLogParams params) {
queryLogBuilder.append(',');
}
- // always log the query last - don't add this to the QueryLogEntry enum
+ // update: stop logging the query itself here, as it will already be
logged in the request handler
+ /*
queryLogBuilder.append("query=")
.append(StringUtils.substring(params._requestContext.getQuery(), 0,
_maxQueryLengthToLog));
+ */
+ queryLogBuilder.setLength(queryLogBuilder.length() - 1);
Review Comment:
I share the same concern. Also, if logs get eventually compressed, having
the same query twice should have a smaller impact.
Reverted for now, the query will be logged twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
