gviedma commented on code in PR #15437:
URL: https://github.com/apache/pinot/pull/15437#discussion_r2027098339
##########
pom.xml:
##########
@@ -271,6 +271,24 @@
<ivy.version>2.5.3</ivy.version>
<c3p0.version>0.11.0-pre2</c3p0.version>
<mchange-commons-java.version>0.3.2</mchange-commons-java.version>
+ <checker-qual.version>3.49.2</checker-qual.version>
+ <groovy-all.version>2.4.21</groovy-all.version>
+ <xml-apis.version>2.0.2</xml-apis.version>
+ <RoaringBitmap.version>1.3.0</RoaringBitmap.version>
+ <jmx_prometheus_javaagent.version>0.19.0</jmx_prometheus_javaagent.version>
+ <fastutil.version>8.5.15</fastutil.version>
+ <disruptor.version>4.0.0</disruptor.version>
+ <snakeyaml.version>2.4</snakeyaml.version>
+
<hadoop-shaded-protobuf_3_25.version>1.4.0</hadoop-shaded-protobuf_3_25.version>
+ <stream.version>2.9.8</stream.version>
Review Comment:
Note that it is not necessary (and often not desirable) for the property
name to match the maven artifactId, since it may be ambiguous outside of the
context of a maven group. The key takeaway is that it should be possible to
look at the property name and understand what this dependency is about, without
having to look for the actual dependency lines. With that in mind, suggest
renaming to something like `clearspring-stream-lib`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
