klsince commented on code in PR #15335: URL: https://github.com/apache/pinot/pull/15335#discussion_r2010670961
########## pinot-core/src/main/java/org/apache/pinot/core/transport/DirectOOMServerHandler.java: ########## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.transport; + +import io.netty.channel.ChannelHandlerContext; +import io.netty.channel.ChannelInboundHandlerAdapter; +import io.netty.channel.socket.ServerSocketChannel; +import io.netty.channel.socket.SocketChannel; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicBoolean; +import org.apache.pinot.common.metrics.ServerMeter; +import org.apache.pinot.common.metrics.ServerMetrics; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Handling netty direct memory OOM. In this case there is a great chance that servers are receiving requests from + * broker concurrently that needs lot of scans on server pusing servers to OOM. We want to close all channels to broker + * to proactively release the direct memory. + */ +public class DirectOOMServerHandler extends ChannelInboundHandlerAdapter { + private static final Logger LOGGER = LoggerFactory.getLogger(DirectOOMServerHandler.class); + private static final AtomicBoolean OOM_SHUTTING_DOWN = new AtomicBoolean(false); + + private final ConcurrentHashMap<SocketChannel, Boolean> _allChannels; + private volatile boolean _silentShutDown = false; + private ServerSocketChannel _serverSocketChannel; + + public DirectOOMServerHandler(ConcurrentHashMap<SocketChannel, Boolean> allChannels, + ServerSocketChannel serverSocketChannel) { + _allChannels = allChannels; + _serverSocketChannel = serverSocketChannel; + } + + public void setSilentShutDown() { + _silentShutDown = true; + } + + /** + * Closes and removes all active channels from the map to release direct memory. + */ + private void closeAllChannels() { + LOGGER.warn("OOM detected: Closing all channels to release direct memory"); + for (SocketChannel channel : _allChannels.keySet()) { + try { + channel.close(); + } catch (Exception e) { + LOGGER.error("Error while closing channel: {}", channel, e); + } finally { + _allChannels.remove(channel); + } + } + } + + void setSilentShutdown() { + if (_serverSocketChannel != null) { + DirectOOMServerHandler directOOMHandler = _serverSocketChannel.pipeline().get(DirectOOMServerHandler.class); + if (directOOMHandler != null) { + directOOMHandler.setSilentShutDown(); + } + } + } + + @Override + public void channelInactive(ChannelHandlerContext ctx) { + // if we are shutting down channels due to direct memory OOM, we short circuit the channel inactive + if (_silentShutDown) { + return; + } + ctx.fireChannelInactive(); + } + + @Override + public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { + if (cause instanceof OutOfMemoryError && cause.getMessage().contains("direct buffer")) { Review Comment: should this be 'Direct buffer', cross-checking with that broker side fix PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
