Jackie-Jiang commented on code in PR #15461:
URL: https://github.com/apache/pinot/pull/15461#discussion_r2029261644
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -83,24 +83,23 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
@VisibleForTesting
public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig) {
- this(port, queryRunner, tlsConfig, ServerMetrics.get(), new
PinotConfiguration());
+ this(port, queryRunner, tlsConfig, new PinotConfiguration());
}
- public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig,
- ServerMetrics serverMetrics, PinotConfiguration config) {
+ public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig, PinotConfiguration config) {
_port = port;
_queryRunner = queryRunner;
_tlsConfig = tlsConfig;
- ExecutorService baseExecutor = Executors.newCachedThreadPool(
- new NamedThreadFactory("query_submission_executor_on_" + _port +
"_port"));
+ ExecutorService baseExecutor =
+ Executors.newCachedThreadPool(new
NamedThreadFactory("query_submission_executor_on_" + _port + "_port"));
Review Comment:
Let me revert the unrelated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
