gortiz commented on code in PR #15461:
URL: https://github.com/apache/pinot/pull/15461#discussion_r2028146404
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##########
@@ -206,8 +206,8 @@ private DimensionTable createFastLookupDimensionTable() {
// loading is in progress.
int token = _loadToken.incrementAndGet();
- Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore,
_tableNameWithType);
- Preconditions.checkState(schema != null, "Failed to find schema for
dimension table: %s", _tableNameWithType);
+ Schema schema = _indexLoadingConfig.getSchema();
+ assert schema != null;
Review Comment:
nit: Not sure why you changed Preconditions to asserts, but you can conserve
error messages by using `assert schema != null : "whatever message that lazyly
evaluates " + someExpression;
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -83,24 +83,23 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
@VisibleForTesting
public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig) {
- this(port, queryRunner, tlsConfig, ServerMetrics.get(), new
PinotConfiguration());
+ this(port, queryRunner, tlsConfig, new PinotConfiguration());
}
- public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig,
- ServerMetrics serverMetrics, PinotConfiguration config) {
+ public QueryServer(int port, QueryRunner queryRunner, @Nullable TlsConfig
tlsConfig, PinotConfiguration config) {
_port = port;
_queryRunner = queryRunner;
_tlsConfig = tlsConfig;
- ExecutorService baseExecutor = Executors.newCachedThreadPool(
- new NamedThreadFactory("query_submission_executor_on_" + _port +
"_port"));
+ ExecutorService baseExecutor =
+ Executors.newCachedThreadPool(new
NamedThreadFactory("query_submission_executor_on_" + _port + "_port"));
Review Comment:
nit: there are some style changes applied here and in QueryRunner that seem
to point that your IDE is automatically applying refactors that are not
required by the codestyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
