KKcorps commented on code in PR #15404:
URL: https://github.com/apache/pinot/pull/15404#discussion_r2019672893
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -557,22 +565,10 @@ private void doAddConsumingSegment(String segmentName)
PartitionDedupMetadataManager partitionDedupMetadataManager =
_tableDedupMetadataManager != null ?
_tableDedupMetadataManager.getOrCreatePartitionManager(partitionGroupId)
: null;
- RealtimeSegmentDataManager realtimeSegmentDataManager;
- try {
- realtimeSegmentDataManager =
- createRealtimeSegmentDataManager(zkMetadata, tableConfig,
indexLoadingConfig, schema, llcSegmentName,
- consumerCoordinator, partitionUpsertMetadataManager,
partitionDedupMetadataManager,
- _isTableReadyToConsumeData);
- } catch (SegmentAlreadyConsumedException e) {
Review Comment:
why remove this? without it, we will not unblock OFFLINE -> CONSUMING helix
threads for segments that are already in completed state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
