Jackie-Jiang commented on code in PR #15404:
URL: https://github.com/apache/pinot/pull/15404#discussion_r2019656629
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumerCoordinator.java:
##########
@@ -299,26 +227,36 @@ AtomicBoolean getFirstTransitionProcessed() {
return _firstTransitionProcessed;
}
- // this should not be used outside of tests.
@VisibleForTesting
- int getMaxSegmentSeqNumLoaded() {
- return _maxSegmentSeqNumRegistered;
+ int getMaxSequenceNumberRegistered() {
+ return _maxSequenceNumberRegistered;
}
@VisibleForTesting
- boolean isSegmentAlreadyConsumed(String currSegmentName) {
- SegmentZKMetadata segmentZKMetadata =
_realtimeTableDataManager.fetchZKMetadata(currSegmentName);
+ void checkSegmentZKMetadataStatus(String segmentName)
+ throws ShouldNotConsumeException {
+ SegmentZKMetadata segmentZKMetadata =
_realtimeTableDataManager.fetchZKMetadataNullable(segmentName);
Review Comment:
This is a bug fix. Existing code directly throw exception when segment is
deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
