noob-se7en commented on code in PR #15296:
URL: https://github.com/apache/pinot/pull/15296#discussion_r2008245657
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1066,7 +1067,7 @@ protected SegmentBuildDescriptor
buildSegmentInternal(boolean forCommit) {
// for partial upsert tables, do not release
_partitionGroupConsumerSemaphore proactively and rely on offload()
// to release the semaphore. This ensures new consuming segment is not
consuming until the segment replacement is
// complete.
- if (_allowConsumptionDuringCommit) {
+ if (_allowConsumptionDuringBuild) {
Review Comment:
> Is it safe to assume buildSegmentInternal() is only called when server has
already consumed the data itself?
Yes.
> would it help to log a msg inside the two if-blocks to help debug, so we
know the reason of releasing semaphore earlier?
Sure. I added a log when we are releasing early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
